2015-11-25 22:36:25
2015-11-25 13:39:06
2015-11-25 13:35:25
5182
addr field for dfrn in contact table
@Friendica Support@Friendica Developers
To be consistent the addr key of the contact table should contain the user address in the format
I have to say it is very hard for me to identify the logic and the responsible code to do this.
After some investigation I would suggest this places which needs get modified:
/mod/dfrn_request.php
/include/user.php
Additionally the hcard needs to be adjusted to contain the
Considerations:
What to do with already existent contacts?
Maybe a automatic bulk update for all dfrn contacts which have no
Note:
At this point this is only some theoretical considerations. Please give feedback about any concerns, possible regressions, missed points.
To be consistent the addr key of the contact table should contain the user address in the format
nickname@friendicainstance.com
. Similar like it's done in the gcontact table.I have to say it is very hard for me to identify the logic and the responsible code to do this.
After some investigation I would suggest this places which needs get modified:
/mod/dfrn_request.php
- https://github.com/friendica/friendica/blob/master/mod/dfrn_request.php#L149
- https://github.com/friendica/friendica/blob/master/mod/dfrn_request.php#L542
/include/user.php
Additionally the hcard needs to be adjusted to contain the
addr
so that scrape_dfrn() could scrape the needed infoConsiderations:
- With registration the
addr
will be genereated in create_user() (something like$nickname . '@' . substr(z_root(), strpos(z_root(),'://') + 3 )
) - include the
addr
in the hcard - adjust dfrn_request.php (look above) so that
addr
will be included for new connections
What to do with already existent contacts?
Maybe a automatic bulk update for all dfrn contacts which have no
addr
entry in the contact table.Note:
At this point this is only some theoretical considerations. Please give feedback about any concerns, possible regressions, missed points.
Michael Vogel
Rabuzarus
https://github.com/friendica/friendica/pull/2013 and
https://github.com/friendica/friendica/pull/2011
What is if poco is disabled?
Shoudn't be the addr available right after registration & connection?
Michael Vogel
Michael Vogel
Rabuzarus
What do you think about an addition in create_user() in the way I wrote in the first post?
Michael Vogel