can you please have a look at the browser dev tools in the js console if it does print any error when a desktop notification should arrive. (And like always after the PR a browser cache refresh needs to be done)

Yesterday I got one desktop notification

I have it
https://github.com/friendica/friendica/blob/develop/js/main.js#L252

The notification e.seen can be false but also 0 (next to 1 -> don't know if we have cases where it is true)

I would like to know if would be better to fix it in the php code. Simple js fix would be && (!e.seen || e.seen == 0) instead of && !e.seen.
But maybe we should have only two states true or false or 0 and 1.

I don't know. The bool values (false) seems to be used for connection requests while the integer (0) seems to be used for post/comments

What do the other devs say?

OK here is a new PR https://github.com/friendica/friendica/pull/3312

I didn't know LibreJS but it's worth checking if Highlight.js, the library I was eyeing, is compatible with.

Furthermore, syntax highlighting is just display sugar, I don't see an issue with it being absent if Javascript is disabled.

Also remember the people who have JS disabled for Malware protection.

The basic core function should also work without js. But on the other side we should make it possible to have good js implementations to have a comfortable modern GUI. The syntax highlighting e.g. is such a case. We shouldn't hardcode such stuff. It federates very bad with other networks and we are bound to a specific library and its way of generating html.