@Friendica Support@Friendica Developers

To be consistent the addr key of the contact table should contain the user address in the format nickname@friendicainstance.com. Similar like it's done in the gcontact table.

I have to say it is very hard for me to identify the logic and the responsible code to do this.

After some investigation I would suggest this places which needs get modified:
/mod/dfrn_request.php

• https://github.com/friendica/friendica/blob/master/mod/dfrn_request.php#L149
  
• https://github.com/friendica/friendica/blob/master/mod/dfrn_request.php#L542

/include/user.php

• https://github.com/friendica/friendica/blob/master/include/user.php#L271

Additionally the hcard needs to be adjusted to contain the addr so that scrape_dfrn() could scrape the needed info

Considerations:

• With registration the addr will be genereated in create_user() (something like $nickname . '@' . substr(z_root(), strpos(z_root(),'://') + 3 ))
  
• include the addr in the hcard
  
• adjust dfrn_request.php (look above) so that addr will be included for new connections

What to do with already existent contacts?
Maybe a automatic bulk update for all dfrn contacts which have no addr entry in the contact table.

Note:
At this point this is only some theoretical considerations. Please give feedback about any concerns, possible regressions, missed points.