@Friendica Developers
Can anybody explain to me how the browser desktop notifications work in friendica? Every time when I log into friendica I get over half an hour different desktop notifications.
Can anybody explain to me how the browser desktop notifications work in friendica? Every time when I log into friendica I get over half an hour different desktop notifications.
3 people like this
Steffen K9 🐰
This can be annoying. I had to disable the notifications because of this problem.
Michael Vogel
Rabuzarus
Tobias
/ping
in the system notification of your OS.Rabuzarus
You will find the description of the issue in the PR description.
@Steffen K9 My friendica network stream isn't very active. Can you have a look if everything does work as expected after the PR got accepted?
https://f.pztrn.name/profile/pztrn
Steffen K9 🐰
Steffen K9 🐰
Steffen K9 🐰
the good news is there is no desktop notification flood anymore. The bad news is I don't get any desktop notifications now. I just tested this with some mentions and a comment. I tried it with Firefox and Chromium. I get the notifications but no desktop notifications.
Rabuzarus
can you please have a look at the browser dev tools in the js console if it does print any error when a desktop notification should arrive. (And like always after the PR a browser cache refresh needs to be done)
Yesterday I got one desktop notification
Rabuzarus
https://github.com/friendica/friendica/blob/develop/js/main.js#L252
The notification
e.seen
can befalse
but also0
(next to1
-> don't know if we have cases where it istrue
)I would like to know if would be better to fix it in the php code. Simple js fix would be
&& (!e.seen || e.seen == 0)
instead of&& !e.seen
.But maybe we should have only two states
true
orfalse
or0
and1
.I don't know. The bool values (
false
) seems to be used for connection requests while the integer (0
) seems to be used for post/commentsWhat do the other devs say?
Steffen K9 🐰
Rabuzarus
Steffen K9 🐰
Aaah!
Fabio
Rabuzarus
!e.seen
didn't work as expected